Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InteractiveUtils.versioninfo(): print the value of Base.Threads.nthreads() #43806

Merged
merged 5 commits into from
Feb 13, 2022
Merged

InteractiveUtils.versioninfo(): print the value of Base.Threads.nthreads() #43806

merged 5 commits into from
Feb 13, 2022

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jan 14, 2022 •
edited
Loading

Hat tip to @tkf for the idea!

@DilumAluthge DilumAluthge requested review from tkf and vtjnash January 14, 2022 02:46
tkf
tkf approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm the one who requested this :)

@DilumAluthge DilumAluthge added the stdlib Julia's standard library label Jan 14, 2022
@johnnychen94
Copy link
Member

johnnychen94 commented Jan 17, 2022 •
edited
Loading

I like it. Since versioninfo() prints JULIA_NUM_THREADS as the desired num threads, it would be meaningful to also show the actual num threads.

vtjnash
vtjnash reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me also

stdlib/InteractiveUtils/src/InteractiveUtils.jl Outdated Show resolved Hide resolved
stdlib/InteractiveUtils/src/InteractiveUtils.jl Show resolved Hide resolved
@DilumAluthge DilumAluthge requested a review from vtjnash February 9, 2022 23:53
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Feb 10, 2022
@DilumAluthge DilumAluthge merged commit 8a9884d into master Feb 13, 2022
@DilumAluthge DilumAluthge deleted the dpa/versioninfo-show-nthreads branch February 13, 2022 07:51
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2022
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
@DilumAluthge @vtjnash @antoine-levitt
InteractiveUtils.versioninfo(): print the value of `Base.Threads.nt…
6580fba 
…hreads()` (JuliaLang#43806)

Co-authored-by: Jameson Nash <[email protected]>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@DilumAluthge @vtjnash @LilithHafner
InteractiveUtils.versioninfo(): print the value of `Base.Threads.nt…
0e2b07b 
…hreads()` (JuliaLang#43806)

Co-authored-by: Jameson Nash <[email protected]>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @vtjnash @LilithHafner
InteractiveUtils.versioninfo(): print the value of `Base.Threads.nt…
d95652a 
…hreads()` (JuliaLang#43806)

Co-authored-by: Jameson Nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkf tkf tkf approved these changes

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DilumAluthge @johnnychen94 @tkf @vtjnash