-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add do-block syntax for Semaphore acquire. Add Semaphore tests #43730
Merged
IanButterworth
merged 6 commits into
JuliaLang:master
from
IanButterworth:ib/acquire_do_syntax
Jan 11, 2022
Merged
Add do-block syntax for Semaphore acquire. Add Semaphore tests #43730
IanButterworth
merged 6 commits into
JuliaLang:master
from
IanButterworth:ib/acquire_do_syntax
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Jan 10, 2022
tkf
added
needs compat annotation
Add !!! compat "Julia x.y" to the docstring
multithreading
Base.Threads and related functionality
labels
Jan 10, 2022
IanButterworth
removed
the
needs compat annotation
Add !!! compat "Julia x.y" to the docstring
label
Jan 10, 2022
tkf
reviewed
Jan 10, 2022
tkf
approved these changes
Jan 10, 2022
@tkf it just occurred to me that the do-block should probably return the return value of I just pushed that and copied the code style from |
tkf
reviewed
Jan 10, 2022
Co-authored-by: Takafumi Arakaki <[email protected]>
quinnj
approved these changes
Jan 11, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…Lang#43730) Co-authored-by: Takafumi Arakaki <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…Lang#43730) Co-authored-by: Takafumi Arakaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add do-block syntax for
Semaphore
acquire
Also, from what I can tell
Semaphore
wasn't tested in Base before this