-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup copy_oftype
-like functions in factorizations
#43700
Conversation
@nanosoldier |
Your package evaluation job has completed - no new issues were detected. A full report can be found here. |
Pinging @daanhb @andreasnoack |
This looks good to me. It is definitely good to reduce the number of the copy_X functions. For the issue with TaylorSeries, I think a problem might still remain if you supply a symmetric matrix with a different eltype (see my comment in #40831, I had replied there before seeing this)? |
I picked up your proposal in the upcoming commit to this PR. I believe we will want get rid of |
Co-authored-by: @daanhb
Works thanks to JuliaLang/julia#43700
* Fix lu method * Cleanup test * Comment (ci.yml) continue-on-error for nightly * Fix a problem introduced in mul! * Revert signature of lu method Works thanks to JuliaLang/julia#43700 * Add tests for inv of Symmetric{Taylor1{T}} matrices * Bump patch version
Co-authored-by: Daan Huybrechs <[email protected]>
Co-authored-by: Daan Huybrechs <[email protected]>
Co-authored-by: Daan Huybrechs <[email protected]>
Minor cleanup after #40831.
I don't think we need non-mutating
lu
- andschur
-methods withStridedMatrix
type in their signature.copy(::StridedMatrix)
does the same ascopy_similar(::StridedMatrix)
, so that reduces the number of needed methods.Closes JuliaDiff/TaylorSeries.jl#295
This now also closes JuliaLang/LinearAlgebra.jl#375 in a much less verbose way than #41288.