Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for package name in [extras] for Preferences #43361

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Look for package name in [extras] for Preferences #43361

merged 2 commits into from
Dec 7, 2021

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Dec 7, 2021

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the [extras] entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

@vchuravy
Look for package name in [extras]
16757cd 
When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24
@vchuravy vchuravy added bugfix This change fixes an existing bug packages Package management and loading labels Dec 7, 2021
@vchuravy vchuravy requested a review from staticfloat December 7, 2021 18:00
@vchuravy
Copy link
Member Author

vchuravy commented Dec 7, 2021

@KristofferC found the right \cite

To circle back to the question that this issue was originally opened to address; we just won't allow setting preferences for things that don't exist in Project.toml. If something doesn't exist, we'll just auto-add it to the extras target and get the mapping into the Project.toml for you.

#37791 (comment)

but we simply forgotten to look into [extras] to get the mapping, despite us adding it automatically.

@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Dec 7, 2021
staticfloat
staticfloat approved these changes Dec 7, 2021
View reviewed changes
base/loading.jl Outdated Show resolved Hide resolved
@vchuravy @staticfloat
Update base/loading.jl
40142b6 
Co-authored-by: Elliot Saba <[email protected]>
@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Dec 7, 2021
@vchuravy vchuravy merged commit 8197c41 into master Dec 7, 2021
@vchuravy vchuravy deleted the vc/pref_proj branch December 7, 2021 22:06
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Dec 9, 2021
KristofferC pushed a commit that referenced this pull request Dec 9, 2021
@vchuravy @KristofferC
Look for package name in [extras] for Preferences (#43361)
a1dd801 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit 8197c41)
@KristofferC KristofferC mentioned this pull request Dec 9, 2021
Merged
15 tasks
KristofferC pushed a commit that referenced this pull request Dec 11, 2021
@vchuravy @KristofferC
Look for package name in [extras] for Preferences (#43361)
0a921be 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit 8197c41)
@vchuravy vchuravy mentioned this pull request Dec 21, 2021
Closed
KristofferC pushed a commit that referenced this pull request Jan 10, 2022
@vchuravy @KristofferC
Look for package name in [extras] for Preferences (#43361)
8079cae 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit 8197c41)
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vchuravy @staticfloat @LilithHafner
Look for package name in [extras] for Preferences (JuliaLang#43361)
47c886e 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vchuravy @staticfloat @LilithHafner
Look for package name in [extras] for Preferences (JuliaLang#43361)
689a194 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @staticfloat
Look for package name in [extras] for Preferences (#43361)
44b6089 
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit 8197c41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug packages Package management and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preferences and transitive dependencies
4 participants
@vchuravy @staticfloat @KristofferC @DilumAluthge