Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libunwind segfaults from JIT frames on FreeBSD #42970

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Nov 6, 2021

This still needs JuliaPackaging/Yggdrasil#3856 so that we can update the JLL version.

Fixes #41943.

@ararslan ararslan added bugfix This change fixes an existing bug external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Nov 6, 2021
@DilumAluthge
Copy link
Member

Does this need to be backported to 1.6 and/or 1.7?

@ararslan ararslan added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 6, 2021
@ararslan ararslan force-pushed the aa/finally-fix-freebsd branch from 9d9b944 to 439f9e2 Compare November 6, 2021 20:26
@ararslan ararslan marked this pull request as ready for review November 6, 2021 20:26
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.
@ararslan ararslan force-pushed the aa/finally-fix-freebsd branch from 439f9e2 to 7353b85 Compare November 6, 2021 22:45
@DilumAluthge DilumAluthge changed the title Fix libunwind segfault Fix libunwind segfaults from JIT frames on FreeBSD Nov 6, 2021
@DilumAluthge DilumAluthge added the ci Continuous integration label Nov 6, 2021
@DilumAluthge DilumAluthge merged commit 96a99c2 into master Nov 7, 2021
@DilumAluthge DilumAluthge deleted the aa/finally-fix-freebsd branch November 7, 2021 00:56
ararslan added a commit that referenced this pull request Nov 7, 2021
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
@vtjnash
Copy link
Member

vtjnash commented Nov 8, 2021

Missing change to stdlib/LibUnwind_jll/Project.toml also?

@ararslan
Copy link
Member Author

ararslan commented Nov 9, 2021

Oh I hadn't considered that, I had forgotten that those are actually part of the repository itself and not external stdlibs that live in JuliaBinaryWrappers. Looks like Project.toml and StdlibArtifacts.toml need to be updated.

@ararslan
Copy link
Member Author

ararslan commented Nov 9, 2021

Actually, StdlibArtifacts.toml seems to be autogenerated (and gets culled by e.g. git clean -fdx) and seems to be correct already. The build version in the Project.toml seems not to actually affect anything. It's currently 0 even though we were using a nonzero build version even before this. So I think we're okay.

KristofferC pushed a commit that referenced this pull request Nov 10, 2021
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
This adds libunwind PR 308 as a patch and updates LibUnwind_jll to use a
version with that patch included.

(cherry picked from commit 96a99c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug ci Continuous integration external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD test segfaults masquerading as unhandled task errors
4 participants