Alternative to writing our own FMA to deal with old glibc #42961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in #26434.
simonbyrne
force-pushed
the
sb/fma-rest
branch
from
1df115d to
cb1e366
Compare
|
since I've already seen libm implementations that just return the wrong results, and we already have pretty good fma emulation in Base (as of 23 hours ago), I don't see a benefit to this. |
|
@simonbyrne since we have an implementation that is passing everywhere (well everywhere except some win64s), should we close this? |
|
Yes, I didn't @oscardssmith had already done it. Yes, that makes way more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #26434.