-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial isequal for VersionNumber #42780
Add partial isequal for VersionNumber #42780
Conversation
4a4ec47
to
1a9a2de
Compare
@StefanKarpinski I'd appreciate a review. In particular I didn't want to add something that would be considered bad for semver best practice |
1a9a2de
to
302c36b
Compare
Given no red flags have been raised I'll go ahead |
I am far from an expert on semver, but this seems a bit weird. I hoped a real expert would chime in. What seems odd to me is that this is symmetric. If you have |
Sorry for post merge review, but I find it kind of strange to add specific keyword arguments to an extended generic function. You can only use the keyword argument if you know the specific type but then why should the generic function be extended at all. The generic function should be documentable and there is no way to document the keyword arguments anymore since they are depending on concrete implementations. This could perhaps be its own function that doesn't extend anything else. |
Ok. Seems I was too eager here for a feature that's only a slight convenience. I'll revert. |
This reverts commit c1f94b6.
Didn't see this, but I'm glad it's reverted. In general, I object to |
Instead of
this provides