Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: remove dead code #42460

Merged
merged 1 commit into from
Oct 2, 2021
Merged

compiler: remove dead code #42460

merged 1 commit into from
Oct 2, 2021

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Oct 1, 2021

  • inlining.jl: UnionSplitSignature (and its SimpleCartesian helper)
    is no longer used
  • abstractinterpretation.jl: the use of precise_container_type seems
    to be introduced in enable/improve constant propagation through varargs methods  #26826, but I think getfield_tfunc at this
    moment is precise enough to propagate elements of constant tuples.

@aviatesk aviatesk requested a review from vtjnash October 1, 2021 18:29
- inferenceresult.jl: just dead allocations
- inlining.jl: `UnionSplitSignature` (and its `SimpleCartesian` helper)
  is no longer used
- abstractinterpretation.jl: the use of `precise_container_type` seems
  to be introduced in #26826, but I think `getfield_tfunc` at this
  moment is precise enough to propagate elements of constant tuples.
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 1, 2021
@aviatesk aviatesk merged commit eb0ab3c into master Oct 2, 2021
@aviatesk aviatesk deleted the avi/deadcode branch October 2, 2021 01:28
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 2, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
- inferenceresult.jl: just dead allocations
- inlining.jl: `UnionSplitSignature` (and its `SimpleCartesian` helper)
  is no longer used
- abstractinterpretation.jl: the use of `precise_container_type` seems
  to be introduced in JuliaLang#26826, but `getfield_tfunc` at this
  moment is precise enough to propagate elements of constant tuples.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
- inferenceresult.jl: just dead allocations
- inlining.jl: `UnionSplitSignature` (and its `SimpleCartesian` helper)
  is no longer used
- abstractinterpretation.jl: the use of `precise_container_type` seems
  to be introduced in JuliaLang#26826, but `getfield_tfunc` at this
  moment is precise enough to propagate elements of constant tuples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants