Avoid testing condition number of random matrices against hard coded numbers #42361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numbers. Instead, use definitions of the condition number of exercise the method for all BlasFloat element types and test a fixed matrix against fixed values to ensure the regressions in opnorm and svdvals would be detected.
andreasnoack
added
test
dkarrasch
approved these changes
Sep 23, 2021
KristofferC
approved these changes
Sep 23, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
…42361) numbers. Instead, use definitions of the condition number of exercise the method for all BlasFloat element types and test a fixed matrix against fixed values to ensure the regressions in opnorm and svdvals would be detected.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…uliaLang#42361) numbers. Instead, use definitions of the condition number of exercise the method for all BlasFloat element types and test a fixed matrix against fixed values to ensure the regressions in opnorm and svdvals would be detected.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…uliaLang#42361) numbers. Instead, use definitions of the condition number of exercise the method for all BlasFloat element types and test a fixed matrix against fixed values to ensure the regressions in opnorm and svdvals would be detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use definitions of the condition number to exercise cond for all BlasFloat element types and test a fixed matrix against fixed values to ensure the regressions in
opnormandsvdvalswould be detected.Triggered by #41558 (review)