compiler: unify singleton_type and argtype_to_function
#42342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They seem to be supposed to do the same thing. Previously `singleton_type` didn't handle the case where `isconstType(ft) -> ft.parameters[1]`, but I think it can just include it.
vtjnash
approved these changes
Sep 22, 2021
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Sep 23, 2021
`argtype_to_function` is factored with `singleton_type`.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 23, 2021
aviatesk
added a commit
to aviatesk/EscapeAnalysis.jl
that referenced
this pull request
Sep 23, 2021
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Sep 23, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
They are supposed to do the same thing. Previously `singleton_type` didn't handle the case where `isconstType(ft) -> ft.parameters[1]`, but it can just include that.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…#42342) They are supposed to do the same thing. Previously `singleton_type` didn't handle the case where `isconstType(ft) -> ft.parameters[1]`, but it can just include that.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…#42342) They are supposed to do the same thing. Previously `singleton_type` didn't handle the case where `isconstType(ft) -> ft.parameters[1]`, but it can just include that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They seem to be supposed to do the same thing.
Previously
singleton_typedidn't handle the case whereisconstType(ft) -> ft.parameters[1], but I think it can just include it.