-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile
: by default, don't initialize with more than 10M samples (even if there are multiple threads); also, fix the Profile
tests when multithreading is enabled
#42254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
bugfix
This change fixes an existing bug
profiler
test
This change adds or pertains to unit tests
labels
Sep 15, 2021
DilumAluthge
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Sep 15, 2021
Okay, so in its current state, this PR fixes the However, there are still failures on Here are the `linux32` failures (click to expand):
The full log is here: https://buildkite.com/julialang/julia-master/builds/3683#00e8a61a-add7-484e-8803-64c8a1b77d76 |
DilumAluthge
force-pushed
the
dpa/profile-tests-multithreading
branch
from
September 15, 2021 10:41
0ca1a88
to
ee5f105
Compare
DilumAluthge
changed the title
Profile tests: fix the tests when multithreading is enabled
Profile: by default, don't initialize with more than 10M samples (even if there are multiple threads); also, fix the Sep 15, 2021
Profile
tests when multithreading is enabled
DilumAluthge
changed the title
Profile: by default, don't initialize with more than 10M samples (even if there are multiple threads); also, fix the
Sep 15, 2021
Profile
tests when multithreading is enabledProfile
: by default, don't initialize with more than 10M samples (even if there are multiple threads); also, fix the Profile
tests when multithreading is enabled
95 tasks
DilumAluthge
force-pushed
the
dpa/profile-tests-multithreading
branch
from
September 15, 2021 10:57
ee5f105
to
ec3cac7
Compare
vtjnash
removed
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42252