Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize findall(f, ::AbstractArray{Bool}) #42202

Merged
merged 9 commits into from
Jun 1, 2022
Merged

Optimize findall(f, ::AbstractArray{Bool}) #42202

merged 9 commits into from
Jun 1, 2022
+39 −8

Commits on Dec 26, 2021

  1. Optimize findall(f, ::AbstractArray{Bool}) 

    * Take shortcuts if f(::Bool) always returns true or false
* Avoid branching in main loop to please branch predictor
* Switch to indexing-agnostic code
* Fix regression mentioned in JuliaLang#42187
    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    1678a1a View commit details
    Browse the repository at this point in the history

  2. Address findall triage comments

    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    d0f3b1f View commit details
    Browse the repository at this point in the history

  3. Guard against uninitialized indices when f is impure

    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    e0bc548 View commit details
    Browse the repository at this point in the history

  4. Only use inbounds on Vector

    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ca24532 View commit details
    Browse the repository at this point in the history

  5. Fix bugs

    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    c73cdc7 View commit details
    Browse the repository at this point in the history

  6. Update base/array.jl 

    Co-authored-by: Milan Bouchet-Valat <[email protected]>
    @jakobnissen @nalimilan
    jakobnissen and nalimilan committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    6453a3b View commit details
    Browse the repository at this point in the history

  7. Fix edge case: No values in findall

    @jakobnissen
    jakobnissen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    3664ba3 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Merge branch 'master' into findallbool

    @aviatesk
    aviatesk authored May 20, 2022
    Configuration menu
    Copy the full SHA
    15dc499 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into findallbool

    @aviatesk
    aviatesk authored May 20, 2022
    Configuration menu
    Copy the full SHA
    61a725c View commit details
    Browse the repository at this point in the history