Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMP: fix warning in init #42062

Merged
merged 1 commit into from
Sep 1, 2021
Merged

GMP: fix warning in init #42062

merged 1 commit into from
Sep 1, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 30, 2021

The warn function does not exist, and error has no effect here (it is wrapped in try/catch)

julia> @eval Base.GMP VERSION = v"1.2.3"
WARNING: redefinition of constant VERSION. This may fail, cause incorrect answers, or produce other errors.
v"1.2.3"

julia> @eval Base.GMP BITS_PER_LIMB = 32
WARNING: redefinition of constant BITS_PER_LIMB. This may fail, cause incorrect answers, or produce other errors.
32

julia> Base.GMP.__init__()
┌ Error: The dynamically loaded GMP library (v"6.2.1" with __gmp_bits_per_limb == 64)
│ does not correspond to the compile time version (v"1.2.3" with __gmp_bits_per_limb == 32).
│ Please rebuild Julia.
└ @ Base.GMP /data/vtjnash/julia1/base/gmp.jl:100
true

julia> @edit Base.GMP.__init__()

julia> Base.GMP.__init__()
WARNING: Error during initialization of module GMP:
ErrorException("could not load library "xlibgmp"
xlibgmp.so: cannot open shared object file: No such file or directory")
true

@vtjnash vtjnash merged commit 4598966 into master Sep 1, 2021
@vtjnash vtjnash deleted the jn/gmp-init-warn branch September 1, 2021 17:53
@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 1, 2021
KristofferC pushed a commit that referenced this pull request Sep 2, 2021
(cherry picked from commit 4598966)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
(cherry picked from commit 4598966)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
(cherry picked from commit 4598966)
@KristofferC KristofferC mentioned this pull request Sep 3, 2021
75 tasks
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 7, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
(cherry picked from commit 4598966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants