avoid loading duplicate libraries #42058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
backport 1.6
We will not use the duplicate, so best to try to avoid loading it.
vtjnash
force-pushed
the
jn/loader_duplicates
branch
from
f2ec633 to
1de1dcd
Compare
|
Why do we need this? The list of libraries that get loaded this way should be quite short, and never share a basename. |
|
Some people pre-load libraries, and this helps avoid confusion |
|
I don't think we should change our behavior by trying to detect |
|
It also seemed to be one of the possible contributing factors to #40246 |
|
Why do you think this is a contributing factor? I don't see a connection. |
63 tasks
|
There's some reports of NULL pointers appearing where they are unexpected, which often is a sign of loading a duplicate library, resulting in the the wrong one being used. This PR solves that. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 2, 2021
We will not use the duplicate, so best to try to avoid loading it. (cherry picked from commit c53669f)
75 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 3, 2021
We will not use the duplicate, so best to try to avoid loading it. (cherry picked from commit c53669f)
KristofferC
pushed a commit
that referenced
this pull request
Sep 6, 2021
We will not use the duplicate, so best to try to avoid loading it. (cherry picked from commit c53669f)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2021
We will not use the duplicate, so best to try to avoid loading it. (cherry picked from commit c53669f)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
We will not use the duplicate, so best to try to avoid loading it.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
We will not use the duplicate, so best to try to avoid loading it.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
We will not use the duplicate, so best to try to avoid loading it. (cherry picked from commit c53669f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will not use the duplicate, so best to try to avoid loading it.