export jl_resolve_globals_in_ir
#42013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be very useful for external `AbstractInterpreter`s to infer (and possibly even optimize) toplevel thunks.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
|
Sort of like with Cthulhu we could do a clean break, and indeed strive for a bit of unification between the two interpreters. It might make sense, though, to redesign the interpretation byte-code (e.g., JuliaDebug/JuliaInterpreter.jl#309) first. |
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
vtjnash
approved these changes
Aug 26, 2021
Yeah, but that side-effects are already involved with method definitions, right ? |
|
Ah, and it looks like you can selectively disable them with setting |
|
Well there are also possibilities that |
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 26, 2021
…ngs (#241) Better to work with <JuliaLang/julia#42013>, but I also added an hacky fallback that makes use of the existing method definition pipeline.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
This would be very useful for external `AbstractInterpreter`s to infer (and possibly even optimize) toplevel thunks.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This would be very useful for external `AbstractInterpreter`s to infer (and possibly even optimize) toplevel thunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be very useful for external
AbstractInterpretersto infer (and possibly even optimize) toplevel thunks.
(like aviatesk/JET.jl#241)
/cc @timholy we may be able to use this to eliminate some special casings within JuliaInterpreter (like resolving toplevel
Symbols asGlobalRefs). The code may end up being more complex on the contrary because of the compatibility with older Julia versions though.