Rename shutdown() to closewrite() #41995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Aug 25, 2021
c42f
force-pushed
the
cjf/rename-shutdown-closewrite
branch
from
6d9e36d to
c039f53
Compare
This name was suggested in #24526 and * Has a good analogy to close(), so people are likely to be able to guess what it means. * Is more specific to IO (conversely, it's easy to imagine shutdown() being wanted for any number of things unrelated to closing the write side of an IO stream).
c42f
force-pushed
the
cjf/rename-shutdown-closewrite
branch
from
c039f53 to
b44f4a9
Compare
|
Will do. The tests failed here in any case because I'd missed the a case of |
Ref: #42005 |
Yep, we're no longer planning on a revert, so there's no issue here. |
|
As a heads up, IOExtras exports a symbol with the same name so anything doing |
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
This name was suggested in JuliaLang#24526 and * Has a good analogy to close(), so people are likely to be able to guess what it means. * Is more specific to IO (conversely, it's easy to imagine shutdown() being wanted for any number of things unrelated to closing the write side of an IO stream).
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This name was suggested in JuliaLang#24526 and * Has a good analogy to close(), so people are likely to be able to guess what it means. * Is more specific to IO (conversely, it's easy to imagine shutdown() being wanted for any number of things unrelated to closing the write side of an IO stream).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutdown()was introduced in #40783. It's exported fromBase, but has not yet been released so renaming is fair game.The name
closewrite()was suggested in #24526 andguess what it means.
being wanted for any number of things unrelated to closing the write
side of an IO stream).
See also discussion at #40783