Mark the Sockets "eof test" as broken on FreeBSD #41983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Aug 24, 2021
ararslan
reviewed
Aug 24, 2021
giordano
reviewed
Aug 24, 2021
stdlib/Sockets/test/runtests.jl
Outdated
Comment on lines
524
to
529
| if Sys.isfreebsd() | ||
| # FIXME: eof test should have closed this by now, but it seems not to on FreeBSD 12 | ||
| @test_broken !isopen(P) | ||
| else | ||
| @test !isopen(P) # eof test should have closed this by now | ||
| end |
There was a problem hiding this comment.
Note that this is equivalent to
@test !isopen(P) broken=Sys.isfreebsd()
Co-authored-by: Alex Arslan <[email protected]>
DilumAluthge
removed
the
merge me
|
I'm closing this in favor of #42004. |
vtjnash
added a commit
that referenced
this pull request
Aug 25, 2021
vtjnash
added a commit
that referenced
this pull request
Aug 26, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
A stream can continue to be read after closewrite, but cannot continue to be written to after seeing EOF. Replaces JuliaLang#42004 Replaces JuliaLang#41983 Fixes JuliaLang#41942 Refs JuliaLang#40783
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
A stream can continue to be read after closewrite, but cannot continue to be written to after seeing EOF. Replaces JuliaLang#42004 Replaces JuliaLang#41983 Fixes JuliaLang#41942 Refs JuliaLang#40783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41942 for context.