-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI (Buildkite): include the short commit hash in the artifact filename #41700
Conversation
15bb64b
to
0ebb2b8
Compare
Can we just use the same name that Julia itself would use? We can use “make print-JULIA_BINARYDIST_FILENAME” to figure it out. |
Sure, that's easy to do when uploading the artifact from the But when we download the artifact from a different builder (e.g. the |
I’m pretty sure we can use wildcards when downloading artifacts.
…On Sun, Jul 25, 2021 at 16:34 Dilum Aluthge ***@***.***> wrote:
Can we just use the same name that Julia itself would use
<https://github.com/JuliaLang/julia/blob/e6e79f7ab4549ab4d6ffbad22038ebfce1368f93/Make.inc#L906>?
We can use “make print-JULIA_BINARYDIST_FILENAME” to figure it out.
Sure, that's easy to do when uploading the artifact from the package
builder.
But when we download the artifact from a different builder (e.g. the
tester builder), we don't have make or the Julia source code. So we need
to be able to construct the name of the artifact on the tester builder
without running make.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#41700 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA762DTGZ5LPT26J2E7CCTTZSNOXANCNFSM5A6IRY4Q>
.
|
a8929b6
to
be118c6
Compare
Looks like the |
99841d5
to
dbba4a9
Compare
No description provided.