Fix firstindex in replace_ref_begin_end (fixes #41630)

[phipsgabler]

I'd appreciate feedback about the tests. I have no idea how to use Revise on Base...

fix #41630

[simeonschaub]

I have no idea how to use Revise on Base...

You just need to build Julia once and when you run it, you can do Revise.track(Base) to pick up all changes inside base/. You can also run the tests with e.g. make test-revise-subarray to run them using Revise.

[simeonschaub]

Thanks! Looks good to me.

[jishnub]

Instead of recreating offsetarrays in the test, would it make more sense to add the tests to test/offsetarray.jl which already uses such an implementation? This might make debugging easier

[simeonschaub]

Yeah, didn't think of that, but that would be nice, so we don't have to duplicate this.

[phipsgabler]

Uh, great, I didn't know that exists. So should I just move over the tests to that file? Or using .Main.OffsetArrays?

[jishnub]

Perhaps moving the test to that file would make more sense, as OffsetArrays is definitely loaded at that point. Also because this fix is specific to OffsetArrays, and the indexing operation (accidentally) works correctly for standard 1-indexed arrays. In any case perhaps adding an extra test for standard arrays to test/subarray.jl might not be a bad idea.

[phipsgabler]

I have moved the tests over to the other file. Something weird was going on with Github merging the upstream, I hope everthing is in good shape now...

Anyway, I'll be on vacation from tomorrow on, so if this is urgent, someone else needs to take care of it now.

[simeonschaub]

Thanks!