-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make precompile files writable #41614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #41614 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 350 350
Lines 73941 73941
=======================================
Hits 60520 60520
Misses 13421 13421 Continue to review full report at Codecov.
|
Perhaps this could explain why some people see packages being precompiled again unexpectedly, if the sort was only respecting creation time, not last used time, and the wrong caches were being tidied up. Also, this might speed things up a bit, with the sort doing the thing it was intended to do. |
71be689
to
7df3587
Compare
(cherry picked from commit 6d58068)
(cherry picked from commit 6d58068)
(cherry picked from commit 6d58068)
(cherry picked from commit 6d58068)
(cherry picked from commit 6d58068)
The combination of #34573 and JuliaLang/Pkg.jl#785 means that the precompile files are currently not writable. This means that our way of updating the use time of precompile filkes in
julia/base/loading.jl
Line 835 in 2893de7
which is then used for sorting:
julia/base/loading.jl
Lines 739 to 742 in 2893de7
is no longer functional.
Fix this by making sure the precompile file is writable.