Do not error when showing invalid enums (#40042) #41596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We definitely do test printing in Base, would be good to add some tests here. |
simeonschaub
added
display and printing
|
Tests should be good now. |
vtjnash
approved these changes
Jul 15, 2021
KristofferC
added
backport 1.6
|
According to #40042 (comment), triage said that the check should be done in printing. |
This was referenced Jul 19, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 19, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 20, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 26, 2021
63 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 31, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 3, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40042 using the code that @vtjnash suggested. I have not added tests due to the principle of not testing printing, but it does solve the problem when manually testing it out.