-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid potential ambiguities for [h/v/hv]cat
in packages
#41511
Conversation
Friendly bump [I need this! :-)] |
I do too 🙂 |
This would be very helpful for me too. See my last succesfull tests with DescriptorSystems with Julia 1.6 and the 174 failed tests with Julia 1.7 due to the |
Seems like this would be useful to people and is unlikely to have any real issues so I would say to just merge this. |
On a separate note, I restarted the two failing CI jobs, just so we can see if CI passes on this PR. |
If this PR resolves the problem, I'm happy, but if anybody knows a remaining reason to revert #41394 speak up. |
#41394 has changed the method signature in concatenation functions involving
UniformScaling
s. This triggers method ambiguities for matrix-related packages, includingLinearMaps.jl
(see JuliaLinearAlgebra/LinearMaps.jl#158). This PR resolves the ambiguity at the root.Closes JuliaLinearAlgebra/LinearMaps.jl#158.