codegen: complete handling for partial-layout objects #41438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
compiler:codegen
|
Any reasonable way to add a test to this? |
JeffBezanson
reviewed
Jul 1, 2021
| if (jl_is_tuple_type(dt)) | ||
| if (dt->name->abstract) | ||
| return 0; | ||
| if (jl_is_tuple_type(dt) || jl_is_namedtuple_type(dt)) |
There was a problem hiding this comment.
Since NamedTuples are invariant is this really necessary?
There was a problem hiding this comment.
They are invariant, but they don't behave properly, so yes, this is necessary to avoid crashes
JeffBezanson
approved these changes
Jul 1, 2021
vtjnash
force-pushed
the
jn/41425
branch
2 times, most recently
from
c545eab to
9847bd5
Compare
vtjnash
added
backport 1.7
merge me
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41425