Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #41363: fix equality of QRCompactWY #41395

Merged
merged 5 commits into from
Jun 29, 2021
Merged

backport #41363: fix equality of QRCompactWY #41395

merged 5 commits into from
Jun 29, 2021

Conversation

simeonschaub
Copy link
Member

@simeonschaub simeonschaub commented Jun 28, 2021 •
edited
Loading

Needs to be manually backported to 1.6 due to qr changes in 1.7.

@simeonschaub
fix equality of QRCompactWY (#41363)
52c40d4 
Equality for `QRCompactWY` did not ignore the subdiagonal entries of
`T` leading to nondeterministic behavior.

This is pulled out from #41228, since this change should be less
controversial than the other changes there and this particular bug just
came up in ChainRules again.
@simeonschaub
use qr(A, Val(true)) instead of ColumnNorm()
14e2932
@simeonschaub simeonschaub added linear algebra Linear algebra bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 equality Issues relating to equality relations: ==, ===, isequal labels Jun 28, 2021
@simeonschaub simeonschaub requested a review from KristofferC June 28, 2021 08:39
@KristofferC KristofferC merged commit 4dd3346 into backports-release-1.6 Jun 29, 2021
@KristofferC KristofferC deleted the sds/backport_41363 branch June 29, 2021 06:56
@KristofferC KristofferC mentioned this pull request Jun 29, 2021
Merged
45 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@simeonschaub @staticfloat
backport #41363: fix equality of QRCompactWY (#41395)
3f36355 
* fix equality of QRCompactWY (#41363)

Equality for `QRCompactWY` did not ignore the subdiagonal entries of
`T` leading to nondeterministic behavior.

This is pulled out from #41228, since this change should be less
controversial than the other changes there and this particular bug just
came up in ChainRules again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug equality Issues relating to equality relations: ==, ===, isequal linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simeonschaub @KristofferC