hvncat: Ensure output ndims are >= the ndims of input arrays
#41201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioTurboNick
force-pushed
the
hvncat-fixes-6
branch
from
2c6f4c0 to
223dead
Compare
BioTurboNick
force-pushed
the
hvncat-fixes-6
branch
from
223dead to
f8b311e
Compare
|
This PR should probably have the 1.7 backport label too? @KristofferC @simeonschaub @JeffBezanson |
82 tasks
|
needs rebase now |
simeonschaub
approved these changes
Jul 16, 2021
|
No worries, the delay was necessary to make sure it would merge correctly |
KristofferC
pushed a commit
that referenced
this pull request
Jul 19, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 20, 2021
petvana
added a commit
to petvana/julia
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking down #41143 into smaller pieces.
This PR ensures the output ndims are at least as large as the ndims of the input arrays.
The max
ndcalculation caused allocations to blow up when I had it in the same method as the remaining code. Removing it to a separate method fixed that.