fix #34288, method errors in nothrow inference of division intrinsics #41178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
vtjnash
reviewed
Jun 10, 2021
base/compiler/tfuncs.jl
Outdated
| @@ -1568,6 +1568,38 @@ end | |||
|
|
|||
| # Query whether the given intrinsic is nothrow | |||
|
|
|||
| function _nthbit(x, n) | |||
There was a problem hiding this comment.
Should we make the @nospecialize explicit for these functions? (IIRC, it is already applied to the whole file)
JeffBezanson
force-pushed
the
jb/fix34288
branch
from
e6f5aa0 to
13b8935
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jun 17, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #34288