make show(::SparseMatrixCSC) more consistent
#41150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added
sparse
This uses the same printing as all other `AbstractArray`s for small sizes. The three-arg `show` used for REPL printing should still behave the same but has been refactored to share more code with the existing methods in Base. closes #41135
simeonschaub
force-pushed
the
sds/show_sparsearray
branch
from
074fb2f to
20e386d
Compare
stevengj
reviewed
Jun 10, 2021
stevengj
reviewed
Jun 13, 2021
stevengj
reviewed
Jun 13, 2021
stevengj
reviewed
Jun 13, 2021
stevengj
approved these changes
Jun 14, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This now always uses `sparse(I, J, K, m, n)` for showing sparse matrices. The three-arg `show` used for REPL printing should still behave the same but has been refactored to share more code with the existing methods in Base. closes JuliaLang#41135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same printing as all other
AbstractArrays for smallsizes. The three-arg
showused for REPL printing should still behavethe same but has been refactored to share more code with the existing
methods in Base.
closes #41135