Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements to hvncat #41143

Closed
wants to merge 36 commits into from
Closed

Refinements to hvncat #41143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
32bdd82
Implement `similar` to allow non-`Array` outputs based on inputs
BioTurboNick Jun 8, 2021
00246df
remove commented line
BioTurboNick Jun 8, 2021
f31b7b8
Add test for similar via BitArrays
BioTurboNick Jun 8, 2021
1409d5f
lower-dimension improvement, tests
BioTurboNick Jun 8, 2021
a8ae12f
Implement rigorous checking for 0 and negative dims
BioTurboNick Jun 8, 2021
cb4c348
More robust argument checking
BioTurboNick Jun 8, 2021
8ff9e2a
consistency in throw syntax
BioTurboNick Jun 8, 2021
3383431
test fixes
BioTurboNick Jun 8, 2021
ceb0f45
Improved performance and bounds checking of shape form
BioTurboNick Jun 8, 2021
fc93dfd
Simplified types
BioTurboNick Jun 9, 2021
bf1cf91
More error checks
BioTurboNick Jun 9, 2021
ae03b0a
Judicious inbounds added back
BioTurboNick Jun 9, 2021
a0f4e4b
fix test
BioTurboNick Jun 9, 2021
28de37d
whitespace fix
BioTurboNick Jun 9, 2021
9e96e7f
remove stray using
BioTurboNick Jun 9, 2021
7e8ab40
Removed unnecessary method
BioTurboNick Jun 9, 2021
6ffbcd0
Organization and documentation
BioTurboNick Jun 9, 2021
ef2fe36
Minor fixups, added argument check to shape method
BioTurboNick Jun 9, 2021
2d09ff3
Added inbounds to dims method
BioTurboNick Jun 9, 2021
13d08f6
More rigorous shape tests
BioTurboNick Jun 9, 2021
8a2dc40
Adjusted inbounds to be more conservative
BioTurboNick Jun 9, 2021
fbf959a
Additional checks to ensure at least one element in vararg
BioTurboNick Jun 9, 2021
3549fe2
Add back ::Number...
BioTurboNick Jun 9, 2021
767185a
Remove some unnecessary tests
BioTurboNick Jun 9, 2021
e0884a9
resolve ambiguity
BioTurboNick Jun 10, 2021
ead8454
Remove unneeded comments
BioTurboNick Jun 10, 2021
34cf142
Stronger shape check
BioTurboNick Jun 10, 2021
2b39480
throw reformat to shorten lines, removed printlns
BioTurboNick Jun 10, 2021
ec7e5f8
Replace looped test with a more specific one
BioTurboNick Jun 10, 2021
06e3276
Added to docstring
BioTurboNick Jun 10, 2021
1e49c1c
Removed commented-out code
BioTurboNick Jun 10, 2021
a499f8d
Resolve ambiguity
BioTurboNick Jun 10, 2021
c171978
whitespace fix
BioTurboNick Jun 10, 2021
2f6b88e
Fixed issue with output dimensionality lower than should be
BioTurboNick Jun 11, 2021
8acaac0
Restored performance
BioTurboNick Jun 11, 2021
7a74647
stronger zero-length dims checks
BioTurboNick Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading