add Xoshiro(seed) constructor, and extend some tests to Xoshiro #41105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
force-pushed
the
rf/xoshiro-constructor
branch
from
9ef049e to
7f686dd
Compare
Usually, a seed should be equally valid for an RNG constructor or for a call to `seed!`, as `seed!`'s docstring mentions: > After the call to seed!, rng is equivalent to a newly created object > initialized with the same seed.
rfourquet
force-pushed
the
rf/xoshiro-constructor
branch
from
7f686dd to
9ab0111
Compare
|
Does this fix some of the regressions in #40065? |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
…aLang#41105) Usually, a seed should be equally valid for an RNG constructor or for a call to `seed!`, as `seed!`'s docstring mentions: > After the call to seed!, rng is equivalent to a newly created object > initialized with the same seed.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…aLang#41105) Usually, a seed should be equally valid for an RNG constructor or for a call to `seed!`, as `seed!`'s docstring mentions: > After the call to seed!, rng is equivalent to a newly created object > initialized with the same seed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, a seed should be equally valid for an RNG constructor or for
a call to
seed!, asseed!'s docstring mentions: