fix #40814, improve type stability of _totuple
#41074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
requested changes
Jun 3, 2021
|
Right. Done. |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
…41074) Replaces JuliaLang#40987, as suggested by JuliaLang#40814.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…41074) Replaces JuliaLang#40987, as suggested by JuliaLang#40814.
82 tasks
|
This looks like it already is on the 1.7 branch so removing backport label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #40987, as suggested by #40814.
We can simply add an annotation to force the return type to be propagated to a caller,
even when inference gives up anywhere in recursed calls.