Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make norm handle missings #40790

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Make norm handle missings #40790

merged 4 commits into from
Nov 2, 2022

Conversation

dkarrasch
Copy link
Member

X-ref #40769.

@dkarrasch dkarrasch added linear algebra Linear algebra missing data Base.missing and related functionality labels May 11, 2021
@ViralBShah
Copy link
Member

This would be nice to update and get merged.

@dkarrasch
Copy link
Member Author

Is this less controversial (than dot) because it doesn't add methods?

@dkarrasch
Copy link
Member Author

@KristofferC What do you think?

@dkarrasch dkarrasch merged commit df06375 into master Nov 2, 2022
@dkarrasch dkarrasch deleted the dk/missingnorm branch November 2, 2022 09:12
@KristofferC
Copy link
Member

Sorry, I don't think missing belongs in the LinearAlgebra module at all :). But that's just my view.

@dkarrasch
Copy link
Member Author

I knew about your skepticism, that's why I shouted out to you. I interpreted silence as "full agreement". 😜 I thought this might be more acceptable because it doesn't add specialized methods, just silently handles that case. And we seem to make a few people happy with it.

@ViralBShah
Copy link
Member

If we don't deal with missing in basic linear algebra, then we just need to replicate all that machinery on the stats side. I agree with @dkarrasch 's assessment here.

@KristofferC
Copy link
Member

If we don't deal with missing in basic linear algebra, then we just need to replicate all that machinery on the stats side.

Not really, you just need to explicitly handle it at the call site (which you have to do in most cases anyway).

If what you want is a function that always returns missing from missing input then let's just add that one function and be done with it (liftmissing). The belief that you can just add these one by one to finally get something consistent is an illusion. Almost any algorithm can be decomposed into "basic math" operations where missing is allegedly supposed to propagate. So you would need to add this special case for virtually every method based on this argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra missing data Base.missing and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants