safepoints are required in any lock than may be used with allocations #40487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
multithreading
(which is pretty much all locks)
vtjnash
force-pushed
the
jn/lock-safepoints
branch
from
b3759f7 to
77e17d1
Compare
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…JuliaLang#40487) (which is pretty much all locks)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…JuliaLang#40487) (which is pretty much all locks)
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…JuliaLang#40487) (which is pretty much all locks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which is pretty much all locks)
This incorrect usage of JL_LOCK_NOGC was causing a deadlock in some code I looked at recently.