Use 0.3.13+4 openblas binaries to fix #40279 #40343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes JuliaLang/LinearAlgebra.jl#833 |
|
Created #40346 with tests. Is this the right way to contribute to an open PR? Or is there a way to contribute without opening a new PR? |
KristofferC
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for #40343 (#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <[email protected]> (cherry picked from commit 58fba2b)
|
Dropping label until JuliaLang/LinearAlgebra.jl#834 is resolved. |
jaakkor2
reviewed
Apr 6, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should add the test for JuliaLang/LinearAlgebra.jl#833 to this PR.
Also some doctest failures. I think those doctests need updating to match the new binaries (looks harmless - some small changes in a couple of calculations, and sign changes in some eigenvector tests).
@pablosanjose Would it be possible for you to provide the test for QZ and the doctest updates?