make find functions sign-sensitive #40007
Conversation
| nothing_sentinel(_search(a, pred.x, i)) | ||
|
|
||
| function _search(a::Union{String,ByteArray}, b::Union{Int8,UInt8}, i::Integer = 1) | ||
| function _search(a::Union{String,ByteArray}, b::Byte, i::Integer = 1) | ||
| if i < 1 | ||
| throw(BoundsError(a, i)) | ||
| end |
There was a problem hiding this comment.
Alternatively?
| end | |
| end | |
| typemin(eltype(a)) <= b <= typemax(eltype(a)) || return 0 |
There was a problem hiding this comment.
Thank you for your suggestion. That looks more elegant. However, I'd like to fix the problem in an upcoming pull request. I'm preparing an overhaul of findnext and friends to improve the consistency and performance, which can be found at https://github.com/bicycle1885/StringSearch.jl. This pull request is a stepping stone and the main purpose is to file an issue I found and add some test to make the next one less complicated. So, if this is acceptable, can you merge as is?
base/strings/search.jl
Outdated
| @@ -1,5 +1,8 @@ | |||
| # This file is a part of Julia. License is MIT: https://julialang.org/license | |||
|
|
|||
| const Byte = Union{Int8,UInt8} | |||
| const ByteArray{T<:Byte} = Vector{T} | |||
There was a problem hiding this comment.
This needs to be Union{Vector{UInt8},Vector{Int8}}; otherwise it includes Vector{Union{Int8,UInt8}}.
There was a problem hiding this comment.
Ah, right. Thank you. Fixed.
|
This pull request is superseded by #40120. |
Fix #40006