Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] basic float16 support (closes #3467) #3980

Merged
merged 4 commits into from
Aug 7, 2013
Merged

[RFC] basic float16 support (closes #3467) #3980

merged 4 commits into from
Aug 7, 2013

Conversation

nolta
Copy link
Member

@nolta nolta commented Aug 7, 2013

The implementation is bit haphazard, but the basics seem to work.

@@ -132,6 +132,8 @@ void __attribute__(()) __stack_chk_fail()
static Type *T_char;
static Type *T_size;
static Type *T_psize;
static Type *T_float16;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't. I just left them in 'cause they're harmless. Easily removed if people prefer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd prefer that. @JeffBezanson ?

Keno added a commit that referenced this pull request Aug 7, 2013
[RFC] basic float16 support (closes #3467)
@Keno Keno merged commit ea1f3b2 into master Aug 7, 2013
@nolta nolta deleted the mn/float16 branch August 8, 2013 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants