-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[p7zip_jll] Set LIBPATH
and LIBPATH_list
at init-time
#39591
Conversation
append!(LIBPATH_list, [joinpath(Sys.BINDIR, Base.LIBDIR, "julia"), joinpath(Sys.BINDIR, Base.LIBDIR)]) | ||
LIBPATH[] = join(LIBPATH_list, pathsep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I could see, most JLLs do something like
julia/stdlib/LibGit2_jll/src/LibGit2_jll.jl
Lines 33 to 34 in 5d7e13f
LIBPATH[] = dirname(libgit2_path) | |
push!(LIBPATH_list, LIBPATH[]) |
because they're libraries, and only need to add to the libpath the directory they're in. However, 7zip is in a different directory, the best I could do was to try both
joinpath(Sys.BINDIR, Base.LIBDIR, "julia")
and joinpath(Sys.BINDIR, Base.LIBDIR)
, is there a better way to find the directory where libstdc++ is?
tester_linux64:
Is there an open issue about this? Logs: https://build.julialang.org/#/builders/71/builds/566/steps/5/logs/stdio |
(cherry picked from commit 4a3537b)
(cherry picked from commit 4a3537b)
Fix #39154, take 2 (or 3?). Ref: docker-library/julia#51 (comment)
Should be backported to
release-1.6