Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p7zip_jll] Set LIBPATH and LIBPATH_list at init-time #39591

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Feb 9, 2021

Fix #39154, take 2 (or 3?). Ref: docker-library/julia#51 (comment)

Should be backported to release-1.6

@DilumAluthge DilumAluthge added the backport 1.6 Change should be backported to release-1.6 label Feb 9, 2021
Comment on lines +88 to +89
append!(LIBPATH_list, [joinpath(Sys.BINDIR, Base.LIBDIR, "julia"), joinpath(Sys.BINDIR, Base.LIBDIR)])
LIBPATH[] = join(LIBPATH_list, pathsep)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could see, most JLLs do something like

LIBPATH[] = dirname(libgit2_path)
push!(LIBPATH_list, LIBPATH[])

because they're libraries, and only need to add to the libpath the directory they're in. However, 7zip is in a different directory, the best I could do was to try both joinpath(Sys.BINDIR, Base.LIBDIR, "julia") and joinpath(Sys.BINDIR, Base.LIBDIR), is there a better way to find the directory where libstdc++ is?

@fredrikekre
Copy link
Member

tester_linux64:

ERROR: LoadError: On worker 23:
UndefRefError: access to undefined reference
Stacktrace:
 [1] getproperty
   @ ./Base.jl:33
 [2] #447
   @ /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.7/Distributed/test/distributed_exec.jl:1607
 [3] #106
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Distributed/src/process_messages.jl:278
 [4] run_work_thunk
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Distributed/src/process_messages.jl:63
 [5] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Distributed/src/process_messages.jl:278 [inlined]
 [6] #105
   @ ./task.jl:406
Stacktrace:
 [1] (::Base.var"#876#878")(x::Task)
   @ Base ./asyncmap.jl:177
 [2] foreach(f::Base.var"#876#878", itr::Vector{Any})
   @ Base ./abstractarray.jl:2146
 [3] maptwice(wrapped_f::Function, chnl::Channel{Any}, worker_tasks::Vector{Any}, c::Vector{Int64})
   @ Base ./asyncmap.jl:177
 [4] wrap_n_exec_twice
   @ ./asyncmap.jl:153 [inlined]
 [5] async_usemap(f::var"#446#448", c::Vector{Int64}; ntasks::Int64, batch_size::Nothing)
   @ Base ./asyncmap.jl:103
 [6] #asyncmap#860
   @ ./asyncmap.jl:81 [inlined]
 [7] asyncmap
   @ ./asyncmap.jl:81 [inlined]
 [8] reuseport_tests()
   @ Main /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.7/Distributed/test/distributed_exec.jl:1601
 [9] top-level scope
   @ /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.7/Distributed/test/distributed_exec.jl:1637
in expression starting at /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.7/Distributed/test/distributed_exec.jl:1636

Is there an open issue about this? Logs: https://build.julialang.org/#/builders/71/builds/566/steps/5/logs/stdio

@fredrikekre fredrikekre merged commit 4a3537b into JuliaLang:master Feb 11, 2021
@giordano giordano deleted the mg/p7zip-libpath branch February 11, 2021 00:52
KristofferC pushed a commit that referenced this pull request Feb 11, 2021
@KristofferC KristofferC mentioned this pull request Feb 11, 2021
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled 7z broken on alpine
5 participants