-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not print delimiters twice in show(::OffsetMatrix) for matrices with certain shifted axes #39522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
changed the title
Fix show for OffsetMatrix
Do not print delimiters twice in show(::OffsetMatrix) for matrices with certain shifted axes
Feb 4, 2021
timholy
reviewed
Feb 6, 2021
kshyatt
added
the
display and printing
Aesthetics and correctness of printed representations of objects.
label
Feb 6, 2021
Test failure seems unrelated |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…th certain shifted axes (JuliaLang#39522)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…th certain shifted axes (JuliaLang#39522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
_show_nonempty
method for anAbstactMatrix
had some assumptions about 1-based indexing that did not hold true forOffsetArray
s. This led to outputs such asThis PR attempts to fix the double delimiters. After this:
and in general
show(X)
should be identical toshow(parent(X))