Fix Markdown word wrap #38502
Merged
Fix Markdown word wrap #38502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36505aa.
This changes one test, but IMO the extra spaces in the test result are not actually desirable. The alignment on Julia 1.5 is also off-by-one, whereas this seems well-aligned.
KristofferC
approved these changes
Nov 30, 2020
nalimilan
added a commit
to JuliaData/DataFrames.jl
that referenced
this pull request
Dec 5, 2020
Since JuliaLang/julia#38502, Markdown printed has changed slightly, making tests fail on nightly.
nalimilan
added a commit
to JuliaData/DataFrames.jl
that referenced
this pull request
Dec 6, 2020
Since JuliaLang/julia#38502, Markdown printed has changed slightly, making tests fail on nightly.
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38275. This changes the output of one test, but IMO the extra spaces in the test result are not actually desirable. The alignment on Julia 1.5 is also off-by-one (see the screenshot in that issue), whereas this seems well-aligned.
Fixing this is one of the milestones for 1.6.