Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make Distributed.Worker threadsafe [Take 2]" #38211

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 28, 2020

Reverts #38134, because we see via the rate of CI failures that Distributed is not ready to be threadsafe.

@jonas-schulze
Copy link
Contributor

I would again suggest to remove the tests (or mark them otherwise as being flaky, maybe a new @test_flaky that differs from @test_broken in that it only logs a passing test). That way we can at least make Distributed threadsafe by parts / in baby steps. As I said before, the issue has very likely nothing to do with the changes you are reverting, rather than the tests that discover new problems.

@vtjnash vtjnash merged commit 4711fc3 into master Oct 30, 2020
@vtjnash vtjnash deleted the revert-38134-vc/threadsafe_distributed branch October 30, 2020 14:50
@vtjnash
Copy link
Member Author

vtjnash commented Oct 30, 2020

Please don't feel discourage by this. It causes problems to leave CI in an unstable state for any length of time. However, that doesn't mean I'm opposed in any way to seeing this work progressed, just that it seems like there's more to be done before Distributed will support being run on a multi-threaded julia!

Keno pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants