Fix tall qr multiplication #38002
Merged
Fix tall qr multiplication #38002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
added
bugfix
dkarrasch
commented
Oct 13, 2020
stdlib/LinearAlgebra/src/qr.jl
Outdated
| mB = size(B, 1) | ||
| mC = size(C, 1) | ||
| if mB < mC | ||
| fill!(C, zero(T)) |
There was a problem hiding this comment.
This may be slightly wasteful, but I couldn't find how to elegantly fill only the complement of C[eachindex(IndexCartesian(), B)] with zeros.
There was a problem hiding this comment.
I guess explicit loops could work, since the dimensionality is fixed. Alternatively:
C[CartesianIndices(B)] .= B
C[CartesianIndices((mB+1:mC, 1:size(C,2))] .= zero(T)
andreasnoack
approved these changes
Oct 20, 2020
Jutho
approved these changes
Oct 20, 2020
stdlib/LinearAlgebra/src/qr.jl
Outdated
| mB = size(B, 1) | ||
| mC = size(C, 1) | ||
| if mB < mC | ||
| fill!(C, zero(T)) |
There was a problem hiding this comment.
I guess explicit loops could work, since the dimensionality is fixed. Alternatively:
C[CartesianIndices(B)] .= B
C[CartesianIndices((mB+1:mC, 1:size(C,2))] .= zero(T)
|
Thanks for this @dkarrasch ; I had forgotten about this issue, and must somehow have missed your PR, despite being mentioned. |
|
I'm marking this for backport, since the |
KristofferC
pushed a commit
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 24750c6)
KristofferC
added a commit
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 24750c6) Co-authored-by: Daniel Karrasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/LinearAlgebra.jl#725. @Jutho