Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update PCRE2 version to 10.34, fixes #35322, fixes #35459." #37713

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

KristofferC
Copy link
Member

Reverts #37688

Still broken: #37688 (comment)

@staticfloat
Copy link
Member

Do we have any idea what's going wrong?

@StefanKarpinski
Copy link
Member

PCRE2 10.35 has been released. It might be worth BinaryBuilding it and seeing if it fixes this issue. In the meantime, it's fine to revert this again. Aside form the two issues it fixes, there's nothing pressing about the upgrade.

@giordano
Copy link
Contributor

PCRE2 10.35 has been released. It might be worth BinaryBuilding

We already have a PR open: JuliaPackaging/Yggdrasil#1687. I'm just a bit worried about compatibilities with downstream libraries..

@musm
Copy link
Contributor

musm commented Sep 24, 2020

PCRE2 10.35 has been released. It might be worth BinaryBuilding it and seeing if it fixes this issue. In the meantime, it's fine to revert this again. Aside form the two issues it fixes, there's nothing pressing about the upgrade.

Yeah, that's actually why I opened that Yggdrasil PR, although @giordano mentioned it's not such a trivial JLL library bump.

@KristofferC KristofferC merged commit 197c8c5 into master Sep 24, 2020
@KristofferC KristofferC deleted the revert-37688-sk/pcre-10.34 branch September 24, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants