-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow standalone dotted ops, parse .op as (. op) #37583
Conversation
It didn't occur to me that with this, |
You certainly know this better than me, but I think currently every operator, with or without the dot, should be its own token, so you should never actually need those parentheses. Even then, these could still be constructed by using the |
From my side, if you don't have any further comments, this should now be ready to do a PkgEval run. |
The test failures seem unrelated. |
Would it be possible to do a PkgEval run now, so this can be discussed in triage tomorrow? |
@JeffBezanson Bump. 🙂 |
👍 from triage. |
@nanosoldier |
PkgEval has migrated systems; let's try this again: @nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
The failures all look unrelated to this PR. 🥳 |
A second attempt at #34156, should supersede #35706. This implements @JeffBezanson's suggestion in #35706 (comment), that we parse
.op
as(. op)
, when it isn't functioning as an operator. We then lower this toBase.BroadcastFunction(op)
, just as in #35706. Could we run PkgEval on this once tests pass to see whether this qualifies as a minor change?closes #34156