Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some issues with buildbot path not updating in stacktraces / method errors #37427

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

KristofferC
Copy link
Member

Fixes #35191

Closes #36216
Closes #35890

@KristofferC KristofferC added the error messages Better, more actionable error messages label Sep 6, 2020
@KristofferC KristofferC force-pushed the kc/stacktrace_stdlib branch 5 times, most recently from d4b722f to 7ae987b Compare September 6, 2020 19:55
@KristofferC KristofferC changed the title fix some issues with buildbot path not updating in stacktraces / method errors WIP: fix some issues with buildbot path not updating in stacktraces / method errors Sep 7, 2020
@KristofferC KristofferC changed the title WIP: fix some issues with buildbot path not updating in stacktraces / method errors fix some issues with buildbot path not updating in stacktraces / method errors Sep 7, 2020
@musm
Copy link
Contributor

musm commented Dec 11, 2020

Any chance we could get this rebased ?

@musm musm added the backport 1.6 Change should be backported to release-1.6 label Dec 11, 2020
@rapus95
Copy link
Contributor

rapus95 commented Jun 1, 2021

bump for 1.7. Though, being a bug in some sense it can be added in a patch release I guess.

@KristofferC KristofferC force-pushed the kc/stacktrace_stdlib branch 2 times, most recently from 6c3cafa to 401b073 Compare August 17, 2021 13:50
@KristofferC KristofferC changed the title fix some issues with buildbot path not updating in stacktraces / method errors WIP: fix some issues with buildbot path not updating in stacktraces / method errors Aug 17, 2021
@anandijain
Copy link
Contributor

yeah would love to have this in 1.7 too.
do you think it will be in 1.7?

@KristofferC KristofferC changed the title WIP: fix some issues with buildbot path not updating in stacktraces / method errors fix some issues with buildbot path not updating in stacktraces / method errors Oct 13, 2021
@KristofferC KristofferC merged commit 1217aa4 into master Oct 13, 2021
@KristofferC KristofferC deleted the kc/stacktrace_stdlib branch October 13, 2021 08:35
@KristofferC
Copy link
Member Author

julia> rand(3) * rand(4,5)
ERROR: DimensionMismatch("A has dimensions (3,1) but B has dimensions (4,5)")
Stacktrace:
 [1] gemm_wrapper!(C::Matrix{Float64}, tA::Char, tB::Char, A::Matrix{Float64}, B::Matrix{Float64}, _add::LinearAlgebra.MulAddMul{true, true, Bool, Bool})
   @ LinearAlgebra ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:590
 [2] mul!
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:149 [inlined]
 [3] mul!
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:255 [inlined]
 [4] *
   @ ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:140 [inlined]
 [5] *(a::Vector{Float64}, B::Matrix{Float64})
   @ LinearAlgebra ~/Downloads/julia-b63d254566/share/julia/stdlib/v1.8/LinearAlgebra/src/matmul.jl:57
 [6] top-level scope
   @ REPL[1]:1

🎉

KristofferC added a commit that referenced this pull request Oct 19, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 error messages Better, more actionable error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to stdlib files is incorrect in stacktraces
5 participants