various DCE-related bugfixes #36888
Closed
various DCE-related bugfixes #36888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phi nodes are optimized away when there is only one predecessor, but this can cause problems in dead loops because forward references can be created, leading to issues with optimization passes that look at all code, dead or not. This fixes issue JuliaLang#29107 when DCE is turned on.
…ot counted This fixes JuliaLang#29253, which was caused by `simple_dce!` erroneously erasing SSA values that did not appear to be used, because these uses were only discovered in `just_fixup!` at the end of iterating over an `IncrementalCompact`.
PR JuliaLang#36684 changes `iterate(IncrementalCompact)` to return an extra index, but leaves its arguments unchanged. However, the PR decremented the index argument in a particular recursive call to `iterate`. This caused `iterate` not to recognise that it was done when `allow_cfg_transforms` was turned on.
Keno
approved these changes
Aug 3, 2020
vtjnash
reviewed
Aug 4, 2020
Comment on lines
-1105
to
-1109
| cresult_bbs = let result_bbs = result_bbs, | ||
| merged_succ = merged_succ, | ||
| merge_into = merge_into, | ||
| bbs = bbs, | ||
| bb_rename_succ = bb_rename_succ |
There was a problem hiding this comment.
Removing the let block prohibits inference of the types of the captured references, which could be a large performance penalty on the inner loops here.
There was a problem hiding this comment.
Good catch, I remember adding this let block for that very reason
JeffBezanson
added
the
compiler:optimizer
vchuravy
added a commit
that referenced
this pull request
Aug 22, 2020
various DCE-related bugfixes (replaces #36888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various DCE-related bugfixes originally from #33730
@Keno @vchuravy