Stop transpose(A) \ lu(B)' from overwriting A #36657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following bug I just found:
```julia
julia> A = randn(5,5)
5×5 Array{Float64,2}:
0.485776 1.29655 0.0790172 0.66021 -1.49472
0.971676 -1.01382 0.630476 0.479027 -0.843428
-0.264609 0.392383 0.646729 0.510696 0.34913
-0.795944 -2.47709 -1.81052 -1.0947 -0.30381
-0.938873 2.16395 -1.33484 -0.745461 1.43709
julia> transpose(A) / lu(randn(5,5))' # should not change A
5×5 Adjoint{Float64,Array{Float64,2}}:
14.36 11.9797 -7.32563 1.87016 -16.2731
-18.4415 -13.7036 10.6455 -2.47396 19.9999
8.0401 8.31723 -5.16714 2.13261 -9.637
4.19849 3.9865 -1.98478 0.714778 -4.62445
-5.36059 -2.60991 0.917052 0.290281 4.62547
julia> A # but does!
5×5 Array{Float64,2}:
14.36 -18.4415 8.0401 4.19849 -5.36059
11.9797 -13.7036 8.31723 3.9865 -2.60991
-7.32563 10.6455 -5.16714 -1.98478 0.917052
1.87016 -2.47396 2.13261 0.714778 0.290281
-16.2731 19.9999 -9.637 -4.62445 4.62547
```
Still need to add tests.
dlfivefifty
changed the title
A
dkarrasch
added
linear algebra
dkarrasch
reviewed
Jul 14, 2020
Co-authored-by: Daniel Karrasch <[email protected]>
dkarrasch
approved these changes
Jul 15, 2020
|
I'd suggest to backport this. EDIT: Interestingly, the problem does not exist on v1.0.5. |
mbauman
reviewed
Jul 15, 2020
mbauman
approved these changes
Jul 15, 2020
|
Test failures seem unrelated... |
JeffBezanson
pushed a commit
that referenced
this pull request
Jul 21, 2020
* Stop transpose(A) \ lu(B)' from overwriting `A`
This fixes the following bug I just found:
```julia
julia> A = randn(5,5)
5×5 Array{Float64,2}:
0.485776 1.29655 0.0790172 0.66021 -1.49472
0.971676 -1.01382 0.630476 0.479027 -0.843428
-0.264609 0.392383 0.646729 0.510696 0.34913
-0.795944 -2.47709 -1.81052 -1.0947 -0.30381
-0.938873 2.16395 -1.33484 -0.745461 1.43709
julia> transpose(A) / lu(randn(5,5))' # should not change A
5×5 Adjoint{Float64,Array{Float64,2}}:
14.36 11.9797 -7.32563 1.87016 -16.2731
-18.4415 -13.7036 10.6455 -2.47396 19.9999
8.0401 8.31723 -5.16714 2.13261 -9.637
4.19849 3.9865 -1.98478 0.714778 -4.62445
-5.36059 -2.60991 0.917052 0.290281 4.62547
julia> A # but does!
5×5 Array{Float64,2}:
14.36 -18.4415 8.0401 4.19849 -5.36059
11.9797 -13.7036 8.31723 3.9865 -2.60991
-7.32563 10.6455 -5.16714 -1.98478 0.917052
1.87016 -2.47396 2.13261 0.714778 0.290281
-16.2731 19.9999 -9.637 -4.62445 4.62547
```
Co-authored-by: Daniel Karrasch <[email protected]>
(cherry picked from commit 94398d1)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* Stop transpose(A) \ lu(B)' from overwriting `A`
This fixes the following bug I just found:
```julia
julia> A = randn(5,5)
5×5 Array{Float64,2}:
0.485776 1.29655 0.0790172 0.66021 -1.49472
0.971676 -1.01382 0.630476 0.479027 -0.843428
-0.264609 0.392383 0.646729 0.510696 0.34913
-0.795944 -2.47709 -1.81052 -1.0947 -0.30381
-0.938873 2.16395 -1.33484 -0.745461 1.43709
julia> transpose(A) / lu(randn(5,5))' # should not change A
5×5 Adjoint{Float64,Array{Float64,2}}:
14.36 11.9797 -7.32563 1.87016 -16.2731
-18.4415 -13.7036 10.6455 -2.47396 19.9999
8.0401 8.31723 -5.16714 2.13261 -9.637
4.19849 3.9865 -1.98478 0.714778 -4.62445
-5.36059 -2.60991 0.917052 0.290281 4.62547
julia> A # but does!
5×5 Array{Float64,2}:
14.36 -18.4415 8.0401 4.19849 -5.36059
11.9797 -13.7036 8.31723 3.9865 -2.60991
-7.32563 10.6455 -5.16714 -1.98478 0.917052
1.87016 -2.47396 2.13261 0.714778 0.290281
-16.2731 19.9999 -9.637 -4.62445 4.62547
```
Co-authored-by: Daniel Karrasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following bug I just found: