fix #36492, ensure output is limited even with basic REPLs #36610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was an unintentional effect from #29249. |
mbauman
added
display and printing
JeffBezanson
approved these changes
Jul 10, 2020
rfourquet
approved these changes
Jul 12, 2020
Yes I totally overlooked that other terminal types existed. (Good catch by the way, I saw the issue without thinking that this could be the cause). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple enough; just unconditionally use an IOContext with
:limit=>trueand then allow the fancier REPLs to further customize.