Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: update jltypes reference diagram for the current v1.6 type system #36504

Closed
wants to merge 1 commit into from

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 1, 2020

Attempted updated of the old type-system categorization diagram to show some of the intent with the current system: https://github.com/JuliaLang/julia/blob/0b5777f1cd0ed1cd193eee08192412d07b2f1ecc/doc/src/assets/jltypes.svg

(somewhat inspired by #25796)

@JeffBezanson
Copy link
Member

Found a couple issues:

  • The isa arrows from UnionAll and Union to DataType are pointing the wrong direction
  • I would not connect Union and Union{}. Instead put TypeofBottom next to Union.
  • isa arrow from Union{} to TypeofBottom goes the wrong way
  • For the criteria for when an immutable is boxed, I would say - might have undefined fields, - is self-referential, or - has too many pointers.

@vtjnash vtjnash closed this May 25, 2023
@vtjnash vtjnash deleted the jn/jltypes.ai branch May 25, 2023 15:56
@vtjnash
Copy link
Member Author

vtjnash commented May 25, 2023

While I think this was a helpful exercise, I think we don't need this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants