Consider terminal emacs in EDITOR_CALLBACKS before graphical #36346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the regex r"\bemacs" matches the cmd `emacs -nw`, the regex r"\bemacs\b.*\s(-nw|--no-window-system)\b" should be considered in the EDITOR_CALLBACKS list before it. Without this change, when JULIA_EDITOR="emacs -nw", julia tries to open the editor with run(...; wait=false) which causes the error: emacs: standard input is not a tty or for emacsclient: emacsclient: could not get terminal name emacsclient: error executing alternate editor ""
rfourquet
reviewed
Jun 18, 2020
| @@ -113,15 +114,16 @@ function define_default_editors() | |||
| define_editor(r".*") do cmd, path, line | |||
| `$cmd $path` | |||
| end | |||
| define_editor([r"\bemacs", "gedit", r"\bgvim"]) do cmd, path, line | |||
There was a problem hiding this comment.
Just out of curiosity, changing r"\bemacs" to r"\bemacs\b" would also work as a fix, right?
EDIT: yeah, my experiments seem to indicate that this also work.
There was a problem hiding this comment.
That still matches emacs -nw?
There was a problem hiding this comment.
If we changed this to r"\bemacs\b", then graphical emacsclient would no longer be matched, so it would end up being caught by the fallback r".*" regex which doesn't jump to line.
rfourquet
approved these changes
Jun 18, 2020
|
For people seeing this issue and wanting a fix for Julia 1.4 and 1.5, you can put the following in startup.jl: (this is copy-pasted and could be simplified but I didn't bother). |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Jun 28, 2020
…ng#36346) Since the regex r"\bemacs" matches the cmd `emacs -nw`, the regex r"\bemacs\b.*\s(-nw|--no-window-system)\b" should be considered in the EDITOR_CALLBACKS list before it. Without this change, when JULIA_EDITOR="emacs -nw", julia tries to open the editor with run(...; wait=false) which causes the error: emacs: standard input is not a tty or for emacsclient: emacsclient: could not get terminal name emacsclient: error executing alternate editor ""
rfourquet
pushed a commit
that referenced
this pull request
Jul 26, 2020
Since the regex r"\bemacs" matches the cmd `emacs -nw`, the regex r"\bemacs\b.*\s(-nw|--no-window-system)\b" should be considered in the EDITOR_CALLBACKS list before it. Without this change, when JULIA_EDITOR="emacs -nw", julia tries to open the editor with run(...; wait=false) which causes the error: emacs: standard input is not a tty or for emacsclient: emacsclient: could not get terminal name emacsclient: error executing alternate editor "" (cherry picked from commit 6385107)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…ng#36346) Since the regex r"\bemacs" matches the cmd `emacs -nw`, the regex r"\bemacs\b.*\s(-nw|--no-window-system)\b" should be considered in the EDITOR_CALLBACKS list before it. Without this change, when JULIA_EDITOR="emacs -nw", julia tries to open the editor with run(...; wait=false) which causes the error: emacs: standard input is not a tty or for emacsclient: emacsclient: could not get terminal name emacsclient: error executing alternate editor ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the regex
r"\bemacs"matches the cmdemacs -nw, the regexr"\bemacs\b.*\s(-nw|--no-window-system)\b"should be considered in theEDITOR_CALLBACKSlist before it.Without this change, when
JULIA_EDITOR="emacs -nw", julia tries toopen the editor with
run(...; wait=false)which causes the error:or for emacsclient:
cc @rfourquet