FileWatching: cleanup timers on return #36301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following my own advice at #36217. Avoids a minor temporary resource leak.
tkf
reviewed
Jun 16, 2020
| @@ -649,10 +649,13 @@ giving the result of the polling. | |||
| function poll_fd(s::Union{RawFD, Sys.iswindows() ? WindowsRawSocket : Union{}}, timeout_s::Real=-1; readable=false, writable=false) | |||
| wt = Condition() | |||
| fdw = _FDWatcher(s, readable, writable) | |||
| local timer | |||
There was a problem hiding this comment.
Just curious, but why not timer = nothing and later timer === nothing || close(timer)? Is it some kind of optimization or just a coding style?
There was a problem hiding this comment.
True, those would be essentially same. So just equivalent variations based on how I started writing it.
staticfloat
approved these changes
Jun 16, 2020
|
There's perhaps a chance this broke something (https://build.julialang.org/#/builders/79/builds/863/steps/5/logs/stdio), though I don't see how, but let's keep an eye on that. |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Jun 28, 2020
Following my own advice at JuliaLang#36217. Avoids a minor temporary resource leak.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Following my own advice at JuliaLang#36217. Avoids a minor temporary resource leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion and my own advice at #36217, this avoids a minor temporary resource leak when using the
timeoutparameter. Can't really be tested as there's no visible side effects to this.