Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test copying a large file #36095

Closed
wants to merge 2 commits into from
Closed

Test copying a large file #36095

wants to merge 2 commits into from

Conversation

jaakkor2
Copy link
Contributor

@jaakkor2 jaakkor2 commented Jun 1, 2020

Test issues

#30989 warns that CI might not like big files, let's see.

jaakkor2 added 2 commits June 1, 2020 09:43
Test issues
* #14574 (fixed)
* #30723 (copy failure on Windows when filesize is >2 GB).

#30989 warns that CI might not like big files, let's see.
@KristofferC
Copy link
Member

Note that testing this was explicitly mentioned in #30989 (comment) and decided against. Just pointing it out for reference.

@ViralBShah ViralBShah added the test This change adds or pertains to unit tests label Jun 1, 2020
@imciner2
Copy link
Contributor

imciner2 commented Jun 3, 2020

Please don't test it this way. Testing using multi GB files would not be good for low memory bandwidth systems (such as some ARM boards) since it would make the already painfully-slow unit testing even slower, and could possibly lead to out of space errors on smaller devices because there are now multiple large files being created.

@jaakkor2
Copy link
Contributor Author

jaakkor2 commented Dec 6, 2020

Testing for #30723 needed, but based on comments this is not the way.

@jaakkor2 jaakkor2 closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants